On 5/13/20 8:36 AM, Eyal Moscovici wrote:
The code handles this case correctly we merely skip the loop. However it
Grammar suggestion: s/correctly we/correctly: we/
is probably best to return an explicit error. Reviewed-by: Eric Blake <ebl...@redhat.com>
R-b still stands.
Acked-by: Mark Kanda <mark.ka...@oracle.com> Signed-off-by: Eyal Moscovici <eyal.moscov...@oracle.com> --- qemu-img.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index cc2e4a3799..23e90a99e1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3091,6 +3091,11 @@ static int img_map(int argc, char **argv) }length = blk_getlength(blk);+ if (length < 0) { + error_report("Failed to get size for '%s'", filename); + return 1; + } + while (curr.start + curr.length < length) { int64_t offset = curr.start + curr.length; int64_t n;
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
