On 5/12/20 9:39 AM, Peter Maydell wrote: > Convert the Neon fp VMAX/VMIN/VMAXNM/VMINNM/VRECPS/VRSQRTS 3-reg-same > insns to decodetree. (These are all the remaining non-accumulation > instructions in this group.) > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > target/arm/neon-dp.decode | 6 +++ > target/arm/translate-neon.inc.c | 70 +++++++++++++++++++++++++++++++++ > target/arm/translate.c | 42 +------------------- > 3 files changed, 78 insertions(+), 40 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > +static bool trans_VMAXNM_fp_3s(DisasContext *s, arg_3same *a) > +{ > + if (!arm_dc_feature(s, ARM_FEATURE_V8)) { > + return false; > + } Indentation is off. > +static bool trans_VMINNM_fp_3s(DisasContext *s, arg_3same *a) > +{ > + if (!arm_dc_feature(s, ARM_FEATURE_V8)) { > + return false; > + } Likewise. r~