On 5/14/20 7:53 AM, John Snow wrote:
Python 3.5 and above do not print a warning when logging is not configured. As a library, it's best practice to leave logging configuration to the client executable.Signed-off-by: John Snow <js...@redhat.com> --- python/qemu/lib/machine.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/python/qemu/lib/machine.py b/python/qemu/lib/machine.py index c31bf7cabb..e92afe8649 100644 --- a/python/qemu/lib/machine.py +++ b/python/qemu/lib/machine.py @@ -110,9 +110,6 @@ def __init__(self, binary, args=None, wrapper=None, name=None, self._console_socket = None self._remove_files = []- # just in case logging wasn't configured by the main script:- logging.basicConfig() - def __enter__(self): return self
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
