On 5/14/20 12:57 AM, Greg Kurz wrote:
> The last two arguments have the bool type. Also, we shouldn't raise an
> exception when using gdbstub.
>
> This was found while reading the code. Since it only affects the powernv
> machine, I didn't dig further to find an actual bug.
>
> Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped
> translation"
> Signed-off-by: Greg Kurz <gr...@kaod.org>
Reviewed-by: Cédric Le Goater <c...@kaod.org>
> ---
> target/ppc/mmu-radix64.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index fb7dfe25ba6f..7ce37cb778db 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -339,7 +339,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
> *cpu, int rwx,
> */
> ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, prtbe_addr,
> pate, &h_raddr, &h_prot,
> - &h_page_size, 1, 1);
> + &h_page_size, true,
> + cause_excp);
> if (ret) {
> return ret;
> }
> @@ -378,7 +379,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
> *cpu, int rwx,
> do {
> ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, pte_addr,
> pate, &h_raddr, &h_prot,
> - &h_page_size, 1, 1);
> + &h_page_size, true,
> + cause_excp);
> if (ret) {
> return ret;
> }
>
