Patchew URL: https://patchew.org/QEMU/20200515060424.18993-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515060424.18993-1-arm...@redhat.com Subject: [PULL 00/21] QOM patches for 2020-05-15 Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200515042231.18201-1-arm...@redhat.com -> patchew/20200515042231.18201-1-arm...@redhat.com * [new tag] patchew/20200515070021.20811-1-arm...@redhat.com -> patchew/20200515070021.20811-1-arm...@redhat.com - [tag update] patchew/cover.1588878756.git.alistair.fran...@wdc.com -> patchew/cover.1588878756.git.alistair.fran...@wdc.com Switched to a new branch 'test' fbbea5a hw: Remove unnecessary DEVICE() cast 9eba9f9 various: Remove unnecessary OBJECT() cast 7cb997f target: Remove unnecessary CPU() cast 2c7b555 qom: Drop @errp parameter of object_property_del() 3c8eae4 spapr_pci: Drop some dead error handling be6aa8a qdev: Unrealize must not fail 9b1686b Drop more @errp parameters after previous commit b142ef6 qom: Drop parameter @errp of object_property_add() & friends 659ef84 qdev: Clean up qdev_connect_gpio_out_named() 787c291 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory a29406f e1000: Don't run e1000_instance_init() twice 2ad2765 hw/isa/superio: Make the components QOM children db1bce4 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256 e871209 tests/check-qom-proplist: Improve iterator coverage d96d67f qom: Drop object_property_set_description() parameter @errp 431f83d qom: Make all the object_property_add_FOO() return the property 1535c09 qom: Drop convenience method object_property_get_uint16List() 65f48e0 qom: Simplify object_property_get_enum() 9f9b4c7 qom: Drop object_property_del_child()'s unused parameter @errp 9d23843 qom: Clean up inconsistent use of gchar * vs. char * 1c41696 qom: Clearer reference counting in object_initialize_childv() === OUTPUT BEGIN === 1/21 Checking commit 1c416969d4df (qom: Clearer reference counting in object_initialize_childv()) 2/21 Checking commit 9d2384330cf0 (qom: Clean up inconsistent use of gchar * vs. char *) 3/21 Checking commit 9f9b4c7d53a3 (qom: Drop object_property_del_child()'s unused parameter @errp) 4/21 Checking commit 65f48e097f23 (qom: Simplify object_property_get_enum()) 5/21 Checking commit 1535c0962264 (qom: Drop convenience method object_property_get_uint16List()) 6/21 Checking commit 431f83d6c8b7 (qom: Make all the object_property_add_FOO() return the property) 7/21 Checking commit d96d67ffbf5d (qom: Drop object_property_set_description() parameter @errp) 8/21 Checking commit e87120907efa (tests/check-qom-proplist: Improve iterator coverage) 9/21 Checking commit db1bce4b2ac1 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256) ERROR: line over 90 characters #59: FILE: target/s390x/cpu_features_def.inc.h:314: +DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256") total: 1 errors, 0 warnings, 8 lines checked Patch 9/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/21 Checking commit 2ad2765df353 (hw/isa/superio: Make the components QOM children) 11/21 Checking commit a29406fbd0dc (e1000: Don't run e1000_instance_init() twice) 12/21 Checking commit 787c29165f1f (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory) 13/21 Checking commit 659ef8412746 (qdev: Clean up qdev_connect_gpio_out_named()) 14/21 Checking commit b142ef68fb7a (qom: Drop parameter @errp of object_property_add() & friends) WARNING: line over 80 characters #211: FILE: backends/hostmem-file.c:187: + file_memory_backend_get_discard_data, file_memory_backend_set_discard_data); WARNING: line over 80 characters #1082: FILE: hw/arm/raspi.c:287: + object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram)); WARNING: line over 80 characters #3116: FILE: hw/ppc/spapr.c:3336: + &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE); total: 0 errors, 3 warnings, 4488 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 9b1686ba4021 (Drop more @errp parameters after previous commit) 16/21 Checking commit be6aa8abdfda (qdev: Unrealize must not fail) 17/21 Checking commit 3c8eae43734a (spapr_pci: Drop some dead error handling) 18/21 Checking commit 2c7b555b17ea (qom: Drop @errp parameter of object_property_del()) 19/21 Checking commit 7cb997fcbbbc (target: Remove unnecessary CPU() cast) 20/21 Checking commit 9eba9f9e7da4 (various: Remove unnecessary OBJECT() cast) 21/21 Checking commit fbbea5a9b1f9 (hw: Remove unnecessary DEVICE() cast) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200515060424.18993-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com