On Fri, 15 May 2020 at 12:07, Aleksandar Markovic
<aleksandar.qemu.de...@gmail.com> wrote:
> I understood your points. They make sense to me. In hindsight, in
> general, we shouldn't try just to silence checkpatch warnings (or, for
> that matter, compiler warnings as well), but try to resolve the root
> cause, the underlying issue, of the warning. In this case, creating
> tracepoints seems to be the right thing to do.
For this sort of "default case, guest accessed a bad register offset"
case, what I usually do is something like
qemu_log_mask(LOG_GUEST_ERROR, "malta_fpga_write: Bad register offset 0x"
TARGET_FMT_lx "\n", addr);
That's a simpler change than adding tracepoints and matches how
we report this kind of guest-did-the-wrong-thing behaviour elsewhere.
thanks
-- PMM
