Cédric Le Goater <c...@kaod.org> writes: > On 5/18/20 7:04 AM, Markus Armbruster wrote: >> pnv_chip_power8_instance_init() creates a "pnv-psi-POWER8" sysbus >> device in a way that leaves it unplugged. >> pnv_chip_power9_instance_init() and pnv_chip_power10_instance_init() >> do the same for "pnv-psi-POWER9" and "pnv-psi-POWER10", respectively. >> >> These devices aren't actually sysbus devices. Correct that. > > I might have done things wrong regarding sysbus in the PowerNV machine. > > For some devices (PHBs), I have added : > > qdev_set_parent_bus(DEVICE(...), sysbus_get_default());
It's not wrong. My next series will rework how devices get plugged into their buses. > Should we do the same for the PSI device ? No, because the PSI device is not a sysbus device.
