On 5/18/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> When trying to consume the DEFINE_EDID_PROPERTIES() macro
> by including "hw/display/edid.h", we get this build failure:
>
> include/hw/display/edid.h:24:5: error: implicit declaration of
> function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
> 24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
> | ^~~~~~~~~~~~~~~~~~
>
> Headers should be self-contained, and one shouldn't have to
> dig to find the missing headers.
> In this case "hw/qdev-properties.h" is missing. Add it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> Since v1: reworded description (rth)
>
> Supersedes: <20200504082003.16298-1-f4...@amsat.org>
> ---
> include/hw/display/edid.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
