On Tue, May 19, 2020 at 8:03 AM Markus Armbruster <arm...@redhat.com> wrote:
>
> Same transformation as in the previous commit. Manual, because
> convincing Coccinelle to transform this case is not worthwhile.
>
> Cc: Alistair Francis <alist...@alistair23.me>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
Looks sane.
Acked-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
> ---
> hw/ssi/ssi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c
> index 54106f5ef8..58e7d904db 100644
> --- a/hw/ssi/ssi.c
> +++ b/hw/ssi/ssi.c
> @@ -16,6 +16,7 @@
> #include "hw/ssi/ssi.h"
> #include "migration/vmstate.h"
> #include "qemu/module.h"
> +#include "qapi/error.h"
>
> struct SSIBus {
> BusState parent_obj;
> @@ -96,9 +97,9 @@ DeviceState *ssi_create_slave_no_init(SSIBus *bus, const
> char *name)
>
> DeviceState *ssi_create_slave(SSIBus *bus, const char *name)
> {
> - DeviceState *dev = ssi_create_slave_no_init(bus, name);
> + DeviceState *dev = qdev_new(name);
>
> - qdev_init_nofail(dev);
> + qdev_realize_and_unref(dev, &bus->parent_obj, &error_fatal);
> return dev;
> }
>
> --
> 2.21.1
>
>
