>> +static void realize_event_facility(DeviceState *dev, Error **errp)
>> +{
>> + SCLPEventFacility *event_facility = EVENT_FACILITY(dev);
>> + Error *local_err = NULL;
>> +
>> + qdev_realize(DEVICE(&event_facility->quiesce),
>> + BUS(&event_facility->sbus), &local_err);
>> + if (local_err) {
>> + error_propagate(errp, local_err);
>> + return;
>> + }
>> + qdev_realize(DEVICE(&event_facility->cpu_hotplug),
>> + BUS(&event_facility->sbus), errp);
>
> Just wondering, do we have to care about un-realizing quiesce in case
> this fails?
Just remembered that we fail creating the machine and therefore abort. So not
necessary :)
>
>> }
>>
>> static void reset_event_facility(DeviceState *dev)
>> @@ -479,6 +467,7 @@ static void init_event_facility_class(ObjectClass
>> *klass, void *data)
>> DeviceClass *dc = DEVICE_CLASS(sbdc);
>> SCLPEventFacilityClass *k = EVENT_FACILITY_CLASS(dc);
>>
>> + dc->realize = realize_event_facility;
>> dc->reset = reset_event_facility;
>> dc->vmsd = &vmstate_event_facility;
>> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>>
>
> LGTM
>
> Reviewed-by: David Hildenbrand <da...@redhat.com>
>
> --
> Thanks,
>
> David / dhildenb
