On Wed, May 20, 2020 at 6:37 PM Bin Meng <bmeng...@gmail.com> wrote: > > Hi Alistair, > > On Thu, May 7, 2020 at 5:02 AM Alistair Francis <alistai...@gmail.com> wrote: > > > > On Tue, May 5, 2020 at 6:34 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > Hi Alistair, > > > > > > On Wed, May 6, 2020 at 6:37 AM Alistair Francis <alistai...@gmail.com> > > > wrote: > > > > > > > > On Tue, May 5, 2020 at 1:34 PM Alistair Francis <alistai...@gmail.com> > > > > wrote: > > > > > > > > > > On Fri, May 1, 2020 at 5:21 AM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > > > > > > From: Bin Meng <bin.m...@windriver.com> > > > > > > > > > > > > Per QEMU deprecated doc, QEMU 4.1 introduced support for the -bios > > > > > > option in QEMU for RISC-V for the virt machine and sifive_u machine. > > > > > > The default behavior has been that QEMU does not automatically load > > > > > > any firmware if no -bios option is included. > > > > > > > > > > > > Now 2 releases passed, it's time to change the default behavior to > > > > > > load the default OpenSBI firmware automatically. The firmware is > > > > > > included with the QEMU release and no user interaction is required. > > > > > > All a user needs to do is specify the kernel they want to boot with > > > > > > the -kernel option. > > > > > > > > > > > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > > > > > > > > > Thanks! > > > > > > > > > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > > > > > > > > > > Applied to the RISC-V tree. > > > > > > > > This fails `make check` > > > > > > > > qemu-system-riscv64: Unable to load the RISC-V firmware > > > > "opensbi-riscv64-spike-fw_jump.elf" > > > > Broken pipe > > > > /scratch/alistair/software/qemu/tests/qtest/libqtest.c:166: > > > > kill_qemu() tried to terminate QEMU process but encountered exit > > > > status 1 (expected 0) > > > > ERROR - too few tests run (expected 7, got 2) > > > > make: *** [/scratch/alistair/software/qemu/tests/Makefile.include:637: > > > > check-qtest-riscv64] Error 1 > > > > > > > > > > Please apply this patch to fix the "make check" as well. > > > > > > [5/5] riscv: Suppress the error report for QEMU testing with > > > riscv_find_firmware() > > > http://patchwork.ozlabs.org/project/qemu-devel/patch/1588348254-7241-6-git-send-email-bmeng...@gmail.com/ > > > > In future please send all related patches in a single series. > > > > I have applied those two patches. > > I checked https://github.com/alistair23/qemu/ but could not find where > these 2 patches applied. Just make sure I was not looking at the wrong > place?
That's the right place, I just hadn't pushed it there yet. I have an internal Git instance that does all the testing so I usually push it there. Alistair > > Regards, > Bin
