Patchew URL: https://patchew.org/QEMU/20200524110121.12686-1-f4...@amsat.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200524110121.12686-1-f4...@amsat.org Subject: [PATCH 0/4] hw/display/cirrus_vga: Convert debug printf() to qemu_log_mask & trace Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' f2c5a76 hw/display/cirrus_vga: Convert debug printf() to trace event 0b01a63 hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf 74d18b7 hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf 9000535 hw/display/cirrus_vga: Convert debug printf() to trace event === OUTPUT BEGIN === 1/4 Checking commit 90005354b7d4 (hw/display/cirrus_vga: Convert debug printf() to trace event) 2/4 Checking commit 74d18b7ca83b (hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf) 3/4 Checking commit 0b01a633fe92 (hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf) ERROR: suspect code indent for conditional statements (16, 12) #31: FILE: hw/display/cirrus_vga.c:1038: if (s->cirrus_blt_pixelwidth > 2) { + qemu_log_mask(LOG_GUEST_ERROR, total: 1 errors, 0 warnings, 156 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit f2c5a7686574 (hw/display/cirrus_vga: Convert debug printf() to trace event) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200524110121.12686-1-f4...@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com