On Sun, 24 May 2020 at 21:21, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > On 5/24/20 9:37 PM, Aleksandar Markovic wrote: > > I agree with all of your patches, they absolutely make sense to me, > > but I would like to know Peter's opinion on such treatment of empty > > slots. > > > > I am going to give r-bs and integrate mips patches as soon as Peter > > OKs the general approach. So, Peter, is Philippe's approach to empty > > slots fine? > > Thanks Aleksandar for looking at this series. > > I expect a neutral opinion from Peter.
Yes. In particular I cannot be the bottleneck for all design choices in QEMU: that doesn't scale. Mostly you can assume that if I have a strong opinion then I'll provide it, and otherwise I prefer it if the people who care enough to maintain code and write patches to tidy it up make the choices. (Empty slots seemed a bit odd to me last time I looked at them, but if they work for mips and sparc that's fine with me.) thanks -- PMM
