Patchew URL: https://patchew.org/QEMU/20200526062252.19852-1-f4...@amsat.org/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200526062252.19852-1-f4...@amsat.org Subject: [PATCH 00/14] hw/display: Omnibus cleanups Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 8960790 hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask() d0b4cb9 hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP) d21b1b3 hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR) e16fcb5 hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion 6aeaa83 hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR) 67b03be hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report() 0ea30c7 hw/display/dpcd: Convert debug printf()s to trace events 870c71a hw/display/dpcd: Fix memory region size 8386530 hw/display/cirrus_vga: Convert debug printf() to trace event 6a156a8 hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf 7bddcc1 hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf 3655560 hw/display/cirrus_vga: Convert debug printf() to trace event 5da1d7d hw/display/cg3: Convert debug printf()s to trace events 5e15cf3 hw/display/edid: Add missing 'qdev-properties.h' header === OUTPUT BEGIN === 1/14 Checking commit 5e15cf344f0d (hw/display/edid: Add missing 'qdev-properties.h' header) 2/14 Checking commit 5da1d7d709c4 (hw/display/cg3: Convert debug printf()s to trace events) 3/14 Checking commit 3655560a1af9 (hw/display/cirrus_vga: Convert debug printf() to trace event) 4/14 Checking commit 7bddcc1ffc45 (hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf) 5/14 Checking commit 6a156a8c7bfd (hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf) ERROR: suspect code indent for conditional statements (16, 12) #31: FILE: hw/display/cirrus_vga.c:1038: if (s->cirrus_blt_pixelwidth > 2) { + qemu_log_mask(LOG_GUEST_ERROR, total: 1 errors, 0 warnings, 156 lines checked Patch 5/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/14 Checking commit 8386530a9c63 (hw/display/cirrus_vga: Convert debug printf() to trace event) 7/14 Checking commit 870c71a9a32f (hw/display/dpcd: Fix memory region size) 8/14 Checking commit 0ea30c7609df (hw/display/dpcd: Convert debug printf()s to trace events) 9/14 Checking commit 67b03be888c2 (hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report()) 10/14 Checking commit 6aeaa836d719 (hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR)) 11/14 Checking commit e16fcb57bdee (hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion) 12/14 Checking commit d21b1b38fe80 (hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR)) 13/14 Checking commit d0b4cb9ec764 (hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)) 14/14 Checking commit 896079058bf6 (hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask()) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200526062252.19852-1-f4...@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com