Peter Maydell <peter.mayd...@linaro.org> writes: [...] > Since we init the device with sysbus_init_child_obj() and > we're in a position here to propagate any realize error > back up to our caller, it would be nicer to do this via > setting the realize property rather than qdev_init_nofail().
I checked all my patches for new uses of qdev_init_nofail(): * PATCH 02: in realize(), but right next to existing uses. I'm not making it worse. * PATCH 03: in helper functions used by board init functions. Okay. * PATCH 08: in a realize method. Can't actually fail, so let's use &error_abort. * PATCH 09 (this one): likewise. * PATCH 18: in a realize method, and in a realize helper that can't fail. One of the callers uses qdev_init_nofail() already. Let's Use &error_abort. [...]