On 27/05/2020 19.35, Alistair Francis wrote: > On Wed, May 27, 2020 at 12:17 AM Thomas Huth <th...@redhat.com> wrote: >> >> On 27/05/2020 00.47, Alistair Francis wrote: >>> >>> include/hw/riscv/spike.h | 6 +- >>> target/riscv/cpu.h | 8 - >>> hw/riscv/spike.c | 217 ------------------ >>> target/riscv/cpu.c | 30 --- >>> target/riscv/cpu_helper.c | 82 +++---- >>> target/riscv/csr.c | 118 ++-------- >>> .../riscv/insn_trans/trans_privileged.inc.c | 18 +- >>> target/riscv/monitor.c | 5 - >>> target/riscv/op_helper.c | 17 +- >>> tests/qtest/machine-none-test.c | 4 +- >>> 10 files changed, 60 insertions(+), 445 deletions(-) >> >> Hi, >> >> looking at the diffstat, I think you should also edit >> ./docs/system/deprecated.rst according to your changes? > > I'm not sure what I should edit there. These are already marked as > deprecated, do I need to make a change when they are removed?
Yes, you should move the features to the "Recently removed features" section at the end of the file. See e.g. commit b4983c570c7a5848c9df. Thomas