28.05.2020 00:57, Eric Blake wrote:
On 5/27/20 4:46 PM, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20200527203733.16129-1-vsement...@virtuozzo.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
TypeError: __init__() got an unexpected keyword argument 'capture_output'
CC /tmp/qemu-test/build/slirp/src/bootp.o
GEN ui/input-keymap-usb-to-qcode.c
make: *** [block/block-gen.c] Error 1
make: *** Deleting file `block/block-gen.c'
make: *** Waiting for unfinished jobs....
GEN ui/input-keymap-win32-to-qcode.c
The more interesting part of the failure:
File "/tmp/qemu-test/src/scripts/coroutine-wrapper.py", line 173, in <module>
print(gen_wrappers_file(sys.stdin.read()))
File "/tmp/qemu-test/src/scripts/coroutine-wrapper.py", line 169, in
gen_wrappers_file
return prettify(res) # prettify to wrap long lines
File "/tmp/qemu-test/src/scripts/coroutine-wrapper.py", line 40, in prettify
encoding='utf-8', input=code, capture_output=True)
File "/usr/lib64/python3.6/subprocess.py", line 423, in run
with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'
which indeed looks like a bug in the patch.
Ah, yes, capture_output is since python 3.7.
So, s/capture_output=True/stdout=subprocess.PIPE/ .
--
Best regards,
Vladimir
