> -----Original Message----- > From: Philippe Mathieu-Daudé <philippe.mathieu.da...@gmail.com> On Behalf Of > Philippe Mathieu-Daudé > Sent: 31 May 2020 18:38 > To: qemu-devel@nongnu.org > Cc: Andrew Jeffery <and...@aj.id.au>; Helge Deller <del...@gmx.de>; Peter > Maydell > <peter.mayd...@linaro.org>; Richard Henderson <r...@twiddle.net>; Eduardo > Habkost > <ehabk...@redhat.com>; Paul Durrant <p...@xen.org>; Hervé Poussineau > <hpous...@reactos.org>; Marcel > Apfelbaum <marcel.apfelb...@gmail.com>; xen-de...@lists.xenproject.org; Paolo > Bonzini > <pbonz...@redhat.com>; Stefano Stabellini <sstabell...@kernel.org>; Cédric Le > Goater <c...@kaod.org>; > qemu-triv...@nongnu.org; Joel Stanley <j...@jms.id.au>; qemu-...@nongnu.org; > Michael S. Tsirkin > <m...@redhat.com>; Anthony Perard <anthony.per...@citrix.com>; > qemu-...@nongnu.org; Philippe Mathieu- > Daudé <f4...@amsat.org> > Subject: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix > definitions > > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/i386/xen/xen-hvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c > index 82ece6b9e7..679d74e6a3 100644 > --- a/hw/i386/xen/xen-hvm.c > +++ b/hw/i386/xen/xen-hvm.c > @@ -9,6 +9,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/units.h" > > #include "cpu.h" > #include "hw/pci/pci.h" > @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms, > * Xen does not allocate the memory continuously, it keeps a > * hole of the size computed above or passed in. > */ > - block_len = (1ULL << 32) + x86ms->above_4g_mem_size; > + block_len = 4 * GiB + x86ms->above_4g_mem_size;
Not strictly necessary but could we retain the brackets please? Paul > } > memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len, > &error_fatal); > -- > 2.21.3
