On 6/4/20 8:15 PM, Paolo Bonzini wrote: > On 04/06/20 08:39, Philippe Mathieu-Daudé wrote: >>> simulate_wrmsr(cpu); >>> } >>> - RIP(env) += rvmcs(cpu->hvf_fd, VMCS_EXIT_INSTRUCTION_LENGTH); >>> + RIP(env) += ins_len; >> I'd feel safer if you change ins_len to uint64_t first. >> > > Why? It will never be more than 15 (it's also a 32-bit field in the VMCS).
Indeed, I am now seeing the comment in target/i386/hvf/vmcs.h:132 /* 32-bit read-only data fields */ #define VMCS_EXIT_INSTRUCTION_LENGTH 0x0000440C So: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks Paolo.