On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote: > Register a yank function which shuts down the socket and sets > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > error occured. > > Signed-off-by: Lukas Straub <lukasstra...@web.de> > --- > Makefile.objs | 1 + > block/nbd.c | 101 ++++++++++++++++++++++++++++++++------------------ > 2 files changed, 65 insertions(+), 37 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index a7c967633a..8e403b81f3 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -18,6 +18,7 @@ block-obj-y += block.o blockjob.o job.o > block-obj-y += block/ scsi/ > block-obj-y += qemu-io-cmds.o > block-obj-$(CONFIG_REPLICATION) += replication.o > +block-obj-y += yank.o
Oh, I see this is repeated for migration and chardev code too. Instead of doing this and relying on linker to merge duplicates, I think we should put yank.c into util/ and built it into util-obj-y, so it gets added to everything. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|