On 6/18/20 9:37 AM, Peter Maydell wrote: >> +/* Return true if tbi bits mean that the access is checked. */ >> +static inline bool tbi_check(uint32_t desc, int bit55) >> +{ >> + return (desc >> (R_MTEDESC_TBI_SHIFT + bit55)) & 1; >> +} >> + >> +/* Return true if tcma bits mean that the access is unchecked. */ >> +static inline bool tcma_check(uint32_t desc, int bit55, int ptr_tag) > > It's a bit confusing that one of these foo_check()s returns > "true for checked access" and the other one returns "true > for unchecked access"...
Yes, but that's true of the hardware bits too. I tried to reverse them but then got confused. r~