Am 20.07.2011 18:23, schrieb Markus Armbruster: > Callees always return 0, except for FreeBSD's cdrom_eject(), which > returns -ENOTSUP when the device is in a terminally wedged state. > > The only caller is bdrv_eject(), and it maps -ENOTSUP to 0 since > commit 4be9762a. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
What about failed ioctls? Currently we only print an error message but still return 0. Is this the right behaviour? Could callers make use of an error return here or would we end up like with bdrv_set_locked() where we can't really communicate the error to the guest? Kevin
