On 6/22/20 6:01 PM, Peter Maydell wrote: > On Sun, 21 Jun 2020 at 13:50, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> >> The following changes since commit 06c4cc3660b366278bdc7bc8b6677032d7b1118c: >> >> qht: Fix threshold rate calculation (2020-06-19 18:29:11 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.com/philmd/qemu.git tags/renesas-hw-20200621 >> >> for you to fetch changes up to 730101266e4026fc19808c740ee4b8118eeaaafe: >> >> docs: Document the RX target (2020-06-21 01:21:47 +0200) >> >> ---------------------------------------------------------------- >> Renesas hardware patches >> >> - Add a common entry for Renesas hardware in MAINTAINERS >> - Trivial SH4 cleanups >> - Add RX GDB simulator from Yoshinori Sato >> >> The Renesas RX target emulation was added in commit c8c35e5f51, >> these patches complete the target by adding the hardware emulation. >> >> Thank you Yoshinori for adding this code to QEMU, and your patience >> during the review process. Now your port is fully integrated. >> >> Travis-CI: >> https://travis-ci.org/github/philmd/qemu/builds/700461815 > > Hi; I'm afraid there's a format-string issue here (manifests > on OSX, openbsd, and 32-bit platforms): > > /home/peter.maydell/qemu/hw/rx/rx-gdbsim.c: In function 'rx_gdbsim_init': > /home/peter.maydell/qemu/hw/rx/rx-gdbsim.c:93:22: error: format '%lli' > expects argument of type 'long long int', but argument 2 has type > 'ram_addr_t {aka unsigned int}' [-Werror=format=] > error_report("Invalid RAM size, should be more than %" PRIi64 " > Bytes", > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mc->default_ram_size); > ~~~~~~~~~~~~~~~~~~~~
I apologize, I missed that while rebasing on Igor's memdev work. I disabled my obsd and win32 builds after they started to fail few months ago and forgot to re-enable them after they were fixed. We recently dropped the Travis-CI OSX builds (commit 22a231950) in favor of Cirrus-CI. There the build succeeded (Mojave): https://cirrus-ci.com/build/6678899172048896 What is different in your OSX setup? I'll respin with: -- >8 -- diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c index 8cd7a438f2..b8a56fa7af 100644 --- a/hw/rx/rx-gdbsim.c +++ b/hw/rx/rx-gdbsim.c @@ -17,6 +17,7 @@ */ #include "qemu/osdep.h" +#include "qemu/cutils.h" #include "qemu/error-report.h" #include "qapi/error.h" #include "qemu-common.h" @@ -90,8 +91,9 @@ static void rx_gdbsim_init(MachineState *machine) const char *dtb_filename = machine->dtb; if (machine->ram_size < mc->default_ram_size) { - error_report("Invalid RAM size, should be more than %" PRIi64 " Bytes", - mc->default_ram_size); + char *sz = size_to_str(mc->default_ram_size); + error_report("Invalid RAM size, should be more than %s", sz); + g_free(sz); } /* Allocate memory space */ ---