On 6/24/20 11:43 AM, Markus Armbruster wrote:
Convertfoo(..., &err); if (err) { ... } to if (!foo(..., &err)) { ... } for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their wrappers isa_realize_and_unref(), pci_realize_and_unref(), sysbus_realize(), sysbus_realize_and_unref(), usb_realize_and_unref(). Coccinelle script:
Automated patching is so much easier than manual :)
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by ARMSSE being used both as typedef and function-like macro there. Convert manually. Eliminate error_propagate() that are now unnecessary. Delete @err that are now unused. Clean up whitespace.
Well, so there's still some manual stuff. But that's okay; hopefully we don't have too many stragglers reintroduced via pending patches.
Signed-off-by: Markus Armbruster <arm...@redhat.com> ---
65 files changed, 248 insertions(+), 768 deletions(-)
Quite a big trim. But I didn't spot any obvious problems. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
