On 23.07.2011, at 23:12, Anthony Liguori wrote: > On 07/23/2011 02:22 PM, Alexander Graf wrote: >> >>> We default off'd the I/O thread even after years we still don't have it >>> enabled. >>> >>> With respect to 0.15, this bit of code is totally isolated from everything >>> else. Worst case scenario, we just disable it on platforms where it >>> doesn't work. It presents no real risk to the stability of the release. >> >> As you've seen, it can break builds. Why not wait for 0.16? The code came in >> more than 2 months after the soft feature freeze, which was specifically for >> big features like this, no? > > I just sent out a patch that should fix the build issue. Let's see what it > takes to resolve this before we talk about disabling for 0.16.
Oh, I'd immediately agree on saying it should be enabled for 0.16 :) > Again, there's zero risk to QEMU for having this enabled so if we can resolve > the build issues, and I don't see why we can't, then there should be no real > problem here. I've just tried out the two patches you sent. With them applied, things compile just fine. Alex