The flash device is exclusively for the host-controlled firmware, so we should not expose it to the OS. Exposing it risks the OS messing with it, which could break firmware runtime services and surprise the OS when all its changes disappear after reboot.
This change was suggested by Ard and Laszlo. Patch 3/4 is the meat. The other patches deal with updating qtest. Thanks, drew Andrew Jones (4): tests/acpi: remove stale allowed tables tests/acpi: virt: allow DSDT acpi table changes hw/arm/virt-acpi-build: Only expose flash on older machine types tests/acpi: virt: update golden masters for DSDT hw/arm/virt-acpi-build.c | 5 ++++- hw/arm/virt.c | 3 +++ include/hw/arm/virt.h | 1 + tests/data/acpi/virt/DSDT | Bin 5307 -> 5205 bytes tests/data/acpi/virt/DSDT.memhp | Bin 6668 -> 6566 bytes tests/data/acpi/virt/DSDT.numamem | Bin 5307 -> 5205 bytes tests/qtest/bios-tables-test-allowed-diff.h | 18 ------------------ 7 files changed, 8 insertions(+), 19 deletions(-) -- 2.25.4
