On 6/29/20 12:28 PM, Aleksandar Markovic wrote:
> понедељак, 29. јун 2020., Philippe Mathieu-Daudé <f4...@amsat.org
> <mailto:f4...@amsat.org>> је написао/ла:
>
> On 6/27/20 9:51 PM, Aleksandar Markovic wrote:
> > This commit creates a new 'Miscellaneous' section which hosts a new
> > 'Performance Tools and Tests' subsection. This subsection will contain
> > the the performance scripts and benchmarks written as a part of the
> > 'TCG Continuous Benchmarking' project. Also, it will be a placeholder
> > for follow-ups to this project, if any.
> >
> > Signed-off-by: Ahmed Karaman <ahmedkhaledkara...@gmail.com
> <mailto:ahmedkhaledkara...@gmail.com>>
> > Reviewed-by: Alex Bennée <alex.ben...@linaro.org
> <mailto:alex.ben...@linaro.org>>
> > Reviewed-by: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com
> <mailto:aleksandar.qemu.de...@gmail.com>>
> > Signed-off-by: Aleksandar Markovic
> <aleksandar.qemu.de...@gmail.com
> <mailto:aleksandar.qemu.de...@gmail.com>>
> > Message-Id: <20200626164546.22102-4-ahmedkhaledkara...@gmail.com
> <mailto:20200626164546.22102-4-ahmedkhaledkara...@gmail.com>>
> > ---
> > MAINTAINERS | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index fe925ea..dec252f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1096,11 +1096,10 @@ F: hw/isa/vt82c686.c
> > F: hw/pci-host/bonito.c
> > F: include/hw/isa/vt82c686.h
> >
> > -Loongson-3 Virtual Platform
> > +Loongson-3 virtual platforms
> > M: Huacai Chen <che...@lemote.com <mailto:che...@lemote.com>>
> > R: Jiaxun Yang <jiaxun.y...@flygoat.com
> <mailto:jiaxun.y...@flygoat.com>>
> > S: Maintained
> > -F: hw/mips/loongson3_virt.c
>
> Ah, now I see, here you unlist the uncommited file.
>
>
> This file/machine, for multiple reasons, will not be accepted in 5.1.
Ah, so that confirms we have to revert commit c012e0b1f9 ("hw/intc: Add
Loongson LIOINTC support"). Can you send a patch please?
> The end user will not be able to see, let alone use the machine in
> question in 5.1. This is on purpose.
>
> This will give enough development time to Huacai to implement missing
> bits and pieces, and to possibly improve the whole idea during 5.2
> development cycle.
Sounds reasonable.
>
> Even though the support that Huacai introduced in 5.1 is, for many
> reasons, not completed, and even though Huacai and I had at times
> opposing views and fierce discussions and disagreements - I salute and
> support his work, and consider it, by far, the best and the most
> important contribution to QEMU for MIPS in years.
>
>
>
> It might be easier to manage sending 2 different pull requests,
> on for MIPS and one for the performance tools.
>
> > F: hw/intc/loongson_liointc.c
> >
> > Boston
> > @@ -3026,3 +3025,10 @@ M: Peter Maydell <peter.mayd...@linaro.org
> <mailto:peter.mayd...@linaro.org>>
> > S: Maintained
> > F: docs/conf.py
> > F: docs/*/conf.py
> > +
> > +Miscellaneous
> > +-------------
> > +Performance Tools and Tests
> > +M: Ahmed Karaman <ahmedkhaledkara...@gmail.com
> <mailto:ahmedkhaledkara...@gmail.com>>
>
> Aleksandar, don't you want to be listed here with Ahmed?
>
>
> Of course not. The project is student's. The mentor just helps and leads
> the student. The fruits of the project belong to the community and to
> the student - and not to the mentor.
>
> If you were the mentor, my impression is that you would leave your name
> in MAINTAINERS whenever you see the slightest opportunity (I remember an
> occasion where you were saying "I worked six hours on this" and then
> proposing yourself as the maitainer for a particular segment (??)).
'??' means you are not sure? Please link reference to discussions.
I volunteered to help maintaining areas when nobody were doing anything,
if that forces others to step in because they are more qualified, I'm
glad I did it. See for example the Renesas ports have qualified
maintainers!
> I
> don't have such approach, and I oppose your approach, and I appeal to
> you to control your apetite for maintainership.
I am not looking for more maintenance, I'm looking to cover abandonned
areas I use. I have been taught by the do-ocracy principle. I'v not been
dropped in as replacement for someone else position, only trying to keep
things unmodified, scared a minimal change would break.
>
> Regards,
> Aleksandar
>
>
>
> > +S: Maintained
> > +F: scripts/performance/
> >
>
