Hi Aleksandar, I know you have sent a v3 of this patch in the meantime, but I would still like to comment on it.
First of all I confirm, that I do not have time to contribute to QEMU anymore and that I said I would like to resign from QEMU maintainership. We discussed that in person in Lyon back in October. I am happy to see that people are interested to take the maintainership. It happens that I known Huacai Chen from the time he was upstreaming the Loongson 3 support to the kernel, I have been testing and reviewing his patches. I also know Jiaxun Yang from the #debian-mips IRC channel. I know that they are both very competent and have a good knowledge of the open source world. I therefore agree that they are good additions to maintain and/or review the MIPS part of QEMU. All that said, they have been contributing only relatively recently to QEMU, and only to some areas. While I do support adding them to those areas, I wonder for example why adding them to the MIPS TCG target or to the Jazz board. That's probably something that should be done in a second step if they have an interest in doing so. I am fully aware that you posted a v3, that fixes exactly that after you got pointed out. However, I am still concerned by the way things happened. Regards, Aurelien On 2020-06-30 18:46, Aleksandar Markovic wrote: > Paul Burton and Aurelien Jarno removed for not being present. > > Huacai Chen and Jiaxun Yang step in as new energy. > > CC: Paul Burton <paulbur...@kernel.org> > CC: Aurelien Jarno <aurel...@aurel32.net> > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > --- > MAINTAINERS | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5d8acf8d31..7fc16e21c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -213,7 +213,8 @@ F: disas/microblaze.c > > MIPS TCG CPUs > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > -R: Aurelien Jarno <aurel...@aurel32.net> > +M: Huacai Chen <che...@lemote.com> > +R: Jiaxun Yang <jiaxun.y...@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Maintained > F: target/mips/ > @@ -377,6 +378,7 @@ F: target/arm/kvm.c > > MIPS KVM CPUs > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > +M: Huacai Chen <che...@lemote.com> > S: Odd Fixes > F: target/mips/kvm.c > > @@ -1052,6 +1054,7 @@ MIPS Machines > ------------- > Jazz > M: Hervé Poussineau <hpous...@reactos.org> > +M: Huacai Chen <che...@lemote.com> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Maintained > F: hw/mips/jazz.c > @@ -1060,8 +1063,8 @@ F: hw/dma/rc4030.c > > Malta > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > +M: Huacai Chen <che...@lemote.com> > M: Philippe Mathieu-Daudé <f4...@amsat.org> > -R: Aurelien Jarno <aurel...@aurel32.net> > S: Maintained > F: hw/isa/piix4.c > F: hw/acpi/piix4.c > @@ -1073,6 +1076,7 @@ F: tests/acceptance/machine_mips_malta.py > > Mipssim > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > +M: Huacai Chen <che...@lemote.com> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Odd Fixes > F: hw/mips/mipssim.c > @@ -1080,7 +1084,6 @@ F: hw/net/mipsnet.c > > R4000 > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > -R: Aurelien Jarno <aurel...@aurel32.net> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Obsolete > F: hw/mips/r4k.c > @@ -1103,7 +1106,8 @@ S: Maintained > F: hw/intc/loongson_liointc.c > > Boston > -M: Paul Burton <pbur...@wavecomp.com> > +M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > +M: Huacai Chen <che...@lemote.com> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Maintained > F: hw/core/loader-fit.c > @@ -2677,7 +2681,8 @@ F: disas/i386.c > > MIPS TCG target > M: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> > -R: Aurelien Jarno <aurel...@aurel32.net> > +M: Huacai Chen <che...@lemote.com> > +R: Jiaxun Yang <jiaxun.y...@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rik...@syrmia.com> > S: Maintained > F: tcg/mips/ > -- > 2.20.1 > > > -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net