On 7/3/20 7:06 PM, Daniel P. Berrangé wrote: > On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote: >> On 07/03/20 18:18, Daniel P. Berrangé wrote: >>> On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote: >>>> Add an entry to cover firmware.json (see commit 3a0adfc9bf: >>>> schema that describes the different uses and properties of >>>> virtual machine firmware). >>>> Cc the libvirt maintainers if it ever changes. >>>> >>>> Cc: Laszlo Ersek <ler...@redhat.com> >>>> Cc: Daniel P. Berrange <berra...@redhat.com> >>>> Cc: Gerd Hoffmann <kra...@redhat.com> >>>> Cc: Kashyap Chamarthy <kcham...@redhat.com> >>>> Cc: Michael S. Tsirkin <m...@redhat.com> >>>> Suggested-by: Laszlo Ersek <ler...@redhat.com> >>>> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>>> --- >>>> Based on a comment from Laszlo: >>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html >>>> >>>> I don't think Laszlo should be the sole maintainer, not sure >>>> who else should be listed. Gerd and Kashyap? :) >>>> Can we add it 'maintained' without specific maintainer? >>>> --- >>>> MAINTAINERS | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index dec252f38b..57c90201df 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h >>>> F: include/hw/i2c/smbus_slave.h >>>> F: include/hw/i2c/smbus_eeprom.h >>>> >>>> +Firmware schema specifications >>>> +M: Laszlo Ersek <ler...@redhat.com> >>>> +R: libvir-l...@redhat.com >>> >>> FWIW, I don't think libvirt needs to review this. Our firmware handling >>> code doesn't really care what specific files exist - it just follows the >>> declared logic to pick amongst whatever exists. >> >> I request that >> >> - Phil be listed please as another maintainer (so there are two people >> that can send pull requests, if a 3rd person needs to patch this file >> for whatever reason), >> >> - Dan be listed please *at least* as an "R" person; the business logic >> written up under the @Firmware element, and lots of the initial review >> comments (in particular the suggestion to mention specific QEMU command >> line switches in the schema), had come from him. >> >> If Dan is willing to be an "M", then we can collapse both of my above >> requests into one, and Phil wouldn't have to be listed (Dan could both >> review suggested changes and submit pull requests). However, I'm raising >> this only as a technical possibility; what really matters to me is that >> Dan be CC'd on suggested changes, and that someone other than me can >> submit PRs if necessary. > > I'm fine with "R", but don't want to be "M" as I don't want to be > responsible for queueing patches, etc on more parts of QEMU.
Thanks all! I'm queuing this patch as: Firmware schema specifications M: Laszlo Ersek <ler...@redhat.com> M: Philippe Mathieu-Daudé <phi...@redhat.com> R: Daniel P. Berrange <berra...@redhat.com> R: Kashyap Chamarthy <kcham...@redhat.com> S: Maintained F: docs/interop/firmware.json Regards, Phil.