Patchew URL: https://patchew.org/QEMU/20200707160613.848843-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200707160613.848843-1-arm...@redhat.com Subject: [PATCH v4 00/45] Less clumsy error checking === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/159413975752.169116.5808968580649255382.st...@bahia.lan -> patchew/159413975752.169116.5808968580649255382.st...@bahia.lan * [new tag] patchew/1594140062-23522-1-git-send-email-aleksandar.qemu.de...@gmail.com -> patchew/1594140062-23522-1-git-send-email-aleksandar.qemu.de...@gmail.com * [new tag] patchew/20200707163504.194740-1-kw...@redhat.com -> patchew/20200707163504.194740-1-kw...@redhat.com Switched to a new branch 'test' 5dad863 hmp: Ignore Error objects where the return value suffices 99fa3f2 qdev: Ignore Error objects where the return value suffices 6ee97c0 qemu-img: Ignore Error objects where the return value suffices 677256f error: Avoid error_propagate() after migrate_add_blocker() 974c52b qapi: Purge error_propagate() from QAPI core b664ca1 qapi: Smooth visitor error checking in generated code 58529e8 qapi: Smooth another visitor error checking pattern 8761cbd block/parallels: Simplify parallels_open() after previous commit 6821adb error: Reduce unnecessary error propagation 8ed0efc error: Eliminate error_propagate() manually 9f8cd51 error: Eliminate error_propagate() with Coccinelle, part 2 4516a2b error: Eliminate error_propagate() with Coccinelle, part 1 e776a9c error: Avoid unnecessary error_propagate() after error_setg() 97a8ae7 qdev: Use returned bool to check for failure, Coccinelle part b489fef qdev: Make functions taking Error ** return bool, not void c5651e9 qom: Make functions taking Error ** return bool, not 0/-1 1e9a1c3 qom: Use returned bool to check for failure, manual part b158de6 qom: Use returned bool to check for failure, Coccinelle part 911dbb4 qom: Make functions taking Error ** return bool, not void 94c4ad1 qom: Put name parameter before value / visitor parameter a65eadc qom: Use return values to check for error where that's simpler aff3f41 qom: Don't handle impossible object_property_get_link() failure f171d59 qom: Crash more nicely on object_property_get_link() failure d1d7b14 qom: Rename qdev_get_type() to object_get_type() 54e907c qom: Use error_reportf_err() instead of g_printerr() in examples aa402c4 s390x/pci: Fix harmless mistake in zpci's property fid's setter e3a01f0 qapi: Use returned bool to check for failure, manual part ee2a4a7 qapi: Use returned bool to check for failure, Coccinelle part d78fd21 qapi: Make visitor functions taking Error ** return bool, not void 45cc0d8 hmp: Eliminate a variable in hmp_migrate_set_parameter() 18fa30f block: Avoid error accumulation in bdrv_img_create() d5fa417 qemu-option: Use returned bool to check for failure 35a4f99 qemu-option: Make functions taking Error ** return bool, not void 9fcbf0b qemu-option: Replace opt_set() by cleaner opt_validate() 09fdc0e qemu-option: Factor out helper opt_create() f2370fc qemu-option: Simplify around find_default_by_name() e8d48f4 qemu-option: Factor out helper find_default_by_name() d9cd2e4 qemu-option: Make uses of find_desc_by_name() more similar 30d78ea qemu-option: Check return value instead of @err where convenient c670e7c virtio-crypto-pci: Tidy up virtio_crypto_pci_realize() 22252c6 macio: Tidy up error handling in macio_newworld_realize() 8c1b98a qdev: Use returned bool to check for qdev_realize() etc. failure 99990ce error: Document Error API usage rules 2ae4ce8 error: Improve error.h's big comment 8d27f64 error: Fix examples in error.h's big comment === OUTPUT BEGIN === 1/45 Checking commit 8d27f64734f9 (error: Fix examples in error.h's big comment) ERROR: Error messages should not contain newlines #25: FILE: include/qapi/error.h:27: + * error_setg(&err, "invalid quark\n" // WRONG! total: 1 errors, 0 warnings, 40 lines checked Patch 1/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/45 Checking commit 2ae4ce84c712 (error: Improve error.h's big comment) 3/45 Checking commit 99990ce2abc0 (error: Document Error API usage rules) 4/45 Checking commit 8c1b98ac618a (qdev: Use returned bool to check for qdev_realize() etc. failure) 5/45 Checking commit 22252c6387fd (macio: Tidy up error handling in macio_newworld_realize()) 6/45 Checking commit c670e7c4698a (virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()) 7/45 Checking commit 30d78eae64ac (qemu-option: Check return value instead of @err where convenient) 8/45 Checking commit d9cd2e4dcb0d (qemu-option: Make uses of find_desc_by_name() more similar) 9/45 Checking commit e8d48f4889b3 (qemu-option: Factor out helper find_default_by_name()) 10/45 Checking commit f2370fcf82c2 (qemu-option: Simplify around find_default_by_name()) 11/45 Checking commit 09fdc0e47ad7 (qemu-option: Factor out helper opt_create()) 12/45 Checking commit 9fcbf0ba2199 (qemu-option: Replace opt_set() by cleaner opt_validate()) 13/45 Checking commit 35a4f997a6c9 (qemu-option: Make functions taking Error ** return bool, not void) 14/45 Checking commit d5fa417a12e9 (qemu-option: Use returned bool to check for failure) 15/45 Checking commit 18fa30f4db6e (block: Avoid error accumulation in bdrv_img_create()) 16/45 Checking commit 45cc0d8cabc8 (hmp: Eliminate a variable in hmp_migrate_set_parameter()) 17/45 Checking commit d78fd21439e0 (qapi: Make visitor functions taking Error ** return bool, not void) WARNING: line over 80 characters #2455: FILE: scripts/qapi/visit.py:26: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_type)sobj, Error **errp); WARNING: line over 80 characters #2523: FILE: scripts/qapi/visit.py:124: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) WARNING: line over 80 characters #2552: FILE: scripts/qapi/visit.py:160: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s *obj, Error **errp) WARNING: line over 80 characters #2567: FILE: scripts/qapi/visit.py:174: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) WARNING: line over 80 characters #2596: FILE: scripts/qapi/visit.py:251: +bool visit_type_%(c_name)s(Visitor *v, const char *name, %(c_name)s **obj, Error **errp) total: 0 errors, 5 warnings, 2413 lines checked Patch 17/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/45 Checking commit ee2a4a7a4d98 (qapi: Use returned bool to check for failure, Coccinelle part) 19/45 Checking commit e3a01f05013a (qapi: Use returned bool to check for failure, manual part) WARNING: Block comments use a leading /* on a separate line #75: FILE: accel/kvm/kvm-all.c:3154: + /* The value was checked in visit_type_OnOffSplit() above. If total: 0 errors, 1 warnings, 187 lines checked Patch 19/45 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/45 Checking commit aa402c440ac8 (s390x/pci: Fix harmless mistake in zpci's property fid's setter) 21/45 Checking commit 54e907c063a7 (qom: Use error_reportf_err() instead of g_printerr() in examples) 22/45 Checking commit d1d7b145ff66 (qom: Rename qdev_get_type() to object_get_type()) 23/45 Checking commit f171d5952fa8 (qom: Crash more nicely on object_property_get_link() failure) 24/45 Checking commit aff3f4122615 (qom: Don't handle impossible object_property_get_link() failure) 25/45 Checking commit a65eadce5022 (qom: Use return values to check for error where that's simpler) 26/45 Checking commit 94c4ad1c16a2 (qom: Put name parameter before value / visitor parameter) 27/45 Checking commit 911dbb46c8d7 (qom: Make functions taking Error ** return bool, not void) 28/45 Checking commit b158de666b89 (qom: Use returned bool to check for failure, Coccinelle part) 29/45 Checking commit 1e9a1c3f4045 (qom: Use returned bool to check for failure, manual part) 30/45 Checking commit c5651e94b8f8 (qom: Make functions taking Error ** return bool, not 0/-1) 31/45 Checking commit b489fef95946 (qdev: Make functions taking Error ** return bool, not void) 32/45 Checking commit 97a8ae7c2a72 (qdev: Use returned bool to check for failure, Coccinelle part) 33/45 Checking commit e776a9cabe79 (error: Avoid unnecessary error_propagate() after error_setg()) 34/45 Checking commit 4516a2baebc6 (error: Eliminate error_propagate() with Coccinelle, part 1) 35/45 Checking commit 9f8cd5132ce5 (error: Eliminate error_propagate() with Coccinelle, part 2) 36/45 Checking commit 8ed0efc8c01d (error: Eliminate error_propagate() manually) 37/45 Checking commit 6821adb9c5bd (error: Reduce unnecessary error propagation) 38/45 Checking commit 8761cbd491e4 (block/parallels: Simplify parallels_open() after previous commit) 39/45 Checking commit 58529e8bf255 (qapi: Smooth another visitor error checking pattern) 40/45 Checking commit b664ca18d216 (qapi: Smooth visitor error checking in generated code) 41/45 Checking commit 974c52baa88b (qapi: Purge error_propagate() from QAPI core) 42/45 Checking commit 677256f9b938 (error: Avoid error_propagate() after migrate_add_blocker()) 43/45 Checking commit 6ee97c0f4cec (qemu-img: Ignore Error objects where the return value suffices) 44/45 Checking commit 99fa3f2a50c1 (qdev: Ignore Error objects where the return value suffices) 45/45 Checking commit 5dad8638ef97 (hmp: Ignore Error objects where the return value suffices) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200707160613.848843-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com