On Tue, 7 Jul 2020 at 13:04, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Tue, Jul 07, 2020 at 12:40:38PM +0100, Peter Maydell wrote: > > On Sat, 4 Jul 2020 at 19:29, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > > > > > > v2 of the pull, fixing non-Linux builds. > > > > > > > > > The following changes since commit > > > fc1bff958998910ec8d25db86cd2f53ff125f7ab: > > > > > > hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 > > > 21:16:10 +0100) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > for you to fetch changes up to f7d98068bf7a0913744dd4ac0a28e8c841df2af5: > > > > > > vhost-vdpa: introduce vhost-vdpa net client (2020-07-04 11:13:50 -0400) > > > > > > ---------------------------------------------------------------- > > > virtio,acpi: features, fixes, cleanups. > > > > > > vdpa support > > > virtio-mem support > > > a handy script for disassembling acpi tables > > > misc fixes and cleanups > > > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > > > > > ---------------------------------------------------------------- > > > > Hi; I'm afraid this fails to build on 32-bit: > > > > /home/peter.maydell/qemu/hw/virtio/vhost-vdpa.c: In function > > 'vhost_vdpa_dma_map': > > /home/peter.maydell/qemu/hw/virtio/vhost-vdpa.c:48:23: error: cast > > from pointer to integer of different size > > [-Werror=pointer-to-int-cast] > > msg.iotlb.uaddr = (uint64_t)vaddr; > > ^ > > > > This should probably be "= (uintptr_t)vaddr". > > > > thanks > > -- PMM > > Precisely. Sorry about missing this. > I made this change and pushed to the same tag - don't want to spam > the list for a small thing like this. Can you pick this up pls? > Commit 849c48004df0e123b53fe9888770cb4f6eb5e8ab now
Sure. (You can always just resend a new v2 cover letter without all the patches; that's what most people do for minor respins.) Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
