On Sun, Jul 12, 2020 at 1:28 AM Alistair Francis <alistai...@gmail.com> wrote: > > On Fri, Jul 10, 2020 at 11:36 AM Alistair Francis <alistai...@gmail.com> > wrote: > > > > On Thu, Jul 9, 2020 at 10:11 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > From: Bin Meng <bin.m...@windriver.com> > > > > > > Update the install blob list to include the generic platform > > > fw_dynamic bios images. > > > > > > Signed-off-by: Bin Meng <bin.m...@windriver.com> > > > > You didn't address the comments in v3. > > > > Thinking about this more though it looks like we currently don't > > install anything, so this is an improvement. > > > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > > Nope, I was wrong. This should be squashed into patch 4 where you > remove the installed binaries.
Not entirely correct. The .bin changes should go to patch 4, and .elf changes should remain in this patch I think. Regards, Bin