On 7/14/20 6:01 PM, Markus Armbruster wrote:
> Help on device properties gets printed to stdout instead of the
> monitor. If you have the monitor anywhere else, no help for you.
> Broken when commit e1043d674d "qdev: use object_property_help()"
> accidentally switched from qemu_printf() to printf(). Switch right
> back.
>
> Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085
> Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> qdev-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 71ebce19df..e9b7228480 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
#pragma GCC poison printf
#pragma GCC poison fprintf
;)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> @@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts)
> }
> g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0);
> for (i = 0; i < array->len; i++) {
> - printf("%s\n", (char *)array->pdata[i]);
> + qemu_printf("%s\n", (char *)array->pdata[i]);
> }
> g_ptr_array_set_free_func(array, g_free);
> g_ptr_array_free(array, true);
>
