From: Alex Richardson <alexander.richard...@cl.cam.ac.uk> After merging latest QEMU upstream into our CHERI fork, I noticed that some of the FPU tests in our MIPS baremetal testsuite [*] started failing. It turns out commit 1ace099f2a accidentally changed add.s into a subtract.
[*] https://github.com/CTSRD-CHERI/cheritest Fixes: 1ace099f2a ("target/mips: fpu: Demacro ADD.<D|S|PS>") Signed-off-by: Alex Richardson <alexander.richard...@cl.cam.ac.uk> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Message-Id: <20200703161515.25966-1-alexander.richard...@cl.cam.ac.uk> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.de...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/mips/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 7a3a61cab3..56beda49d8 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1221,7 +1221,7 @@ uint32_t helper_float_add_s(CPUMIPSState *env, { uint32_t wt2; - wt2 = float32_sub(fst0, fst1, &env->active_fpu.fp_status); + wt2 = float32_add(fst0, fst1, &env->active_fpu.fp_status); update_fcr31(env, GETPC()); return wt2; } -- 2.21.3
