Philippe Mathieu-Daudé <phi...@redhat.com> writes: > error_vprepend() is only used by util/error.c where it is > defined. Make it static to reduce its scope. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > include/qapi/error.h | 6 ------ > util/error.c | 6 +++++- > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/include/qapi/error.h b/include/qapi/error.h > index 7932594dce..fa2308dedd 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -384,12 +384,6 @@ void error_propagate(Error **dst_errp, Error *local_err); > void error_propagate_prepend(Error **dst_errp, Error *local_err, > const char *fmt, ...); > > -/* > - * Prepend some text to @errp's human-readable error message. > - * The text is made by formatting @fmt, @ap like vprintf(). > - */ > -void error_vprepend(Error *const *errp, const char *fmt, va_list ap); > - > /* > * Prepend some text to @errp's human-readable error message. > * The text is made by formatting @fmt, ... like printf(). > diff --git a/util/error.c b/util/error.c > index b6c89d1412..3990b741ff 100644 > --- a/util/error.c > +++ b/util/error.c > @@ -121,7 +121,11 @@ void error_setg_file_open_internal(Error **errp, > "Could not open '%s'", filename); > } > > -void error_vprepend(Error *const *errp, const char *fmt, va_list ap) > +/* > + * Prepend some text to @errp's human-readable error message. > + * The text is made by formatting @fmt, @ap like vprintf(). > + */ > +static void error_vprepend(Error *const *errp, const char *fmt, va_list ap) > { > GString *newmsg;
I prefer to keep error_vprepend() in error.h even though it's only used in error.c at the moment. In an external library interface, every ... function needs a va_list buddy. This is an internal interface, where providing only a ... function is just fine. I happily do that when I have no use fo the va_list function. But when the va_list function exists, hiding it buys us nothing.