On 2/19/20 8:20 AM, Vladimir Sementsov-Ogievskiy wrote:
18.02.2020 14:00, Andrey Shinkevich wrote:
On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote:
Rename dirty_bitmap_mig_cleanup to dirty_bitmap_do_save_cleanup, to
stress that it is on save part.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
migration/block-dirty-bitmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
At the next opportunity, I would suggest the name like
"dirty_bitmap_do_clean_after_saving()"
and similar for dirty_bitmap_save_cleanup()
"dirty_bitmap_clean_after_saving()".
I'd keep my naming, it corresponds to .save_cleanup handler name.
I'm fine with that explanation, so no need to rename again.
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Andrey Shinkevich <andrey.shinkev...@virtuozzo.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org