Am 29.07.2011 16:24, schrieb Aneesh Kumar K.V: > On Fri, 29 Jul 2011 14:53:14 +0200, Kevin Wolf <kw...@redhat.com> wrote: >> Am 27.07.2011 18:21, schrieb Aneesh Kumar K.V: >>> Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> >>> --- >>> qemu-coroutine-lock.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ >>> qemu-coroutine.h | 12 ++++++++++++ >>> 2 files changed, 56 insertions(+), 0 deletions(-) >> >> Looks good to me. >> >> What's your plan with getting this merged? Are you going to just include >> it with another series that you'll send once the basic coroutine support >> is in? > > Since the patch already is dependent on CoQueue, it would be nice if you > can push it through your tree. I will stage the dependent VirtFS patch > after that get merged upstream.
Okay, I applied it to my branch so that I won't forget about it, but while merging I noticed two things that you could fix: The patch adds an #include "qemu-thread.h" to qemu-coroutine.h for apparently no reason, and it would be nice to have comments in qemu-coroutine.h like all other functions have. Kevin