On Thu, 30 Jul 2020 11:25:06 +0100 Daniel P. Berrangé <berra...@redhat.com> wrote:
> > /* make a NUL-terminated string */ > > - loadparm_str = g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1); > > - loadparm_str[sizeof(ms->loadparm)] = 0; > > + loadparm_str = g_malloc0(sizeof(ms->loadparm) + 1); > > + memcpy(loadparm_str, ms->loadparm, sizeof(ms->loadparm)); > > I feel like g_strndup(ms->loadparm, sizeof(ms->loadparm)) > is what should have been used here. > > It copies N characters, but allocates N+1 adding a trailing NUL > which are the semantic we wanted here. I agree. Thanks for pointing this out. I'm not very familiar with the string utilities of glib. Regards, Halil
