On 8/3/20 6:28 AM, Peter Maydell wrote:
> In arm_tr_init_disas_context() we have a FIXME comment that suggests
> "cpu_M0 can probably be the same as cpu_V0".  This isn't in fact
> possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(),
> and that function is called in various places where cpu_M0 contains a
> live value (i.e.  between gen_op_iwmmxt_movq_M0_wRn() and
> gen_op_iwmmxt_movq_wRn_M0() calls).  Remove the comment.
> 
> We also have a comment on the declarations of cpu_V0/V1/M0 which
> claims they're "for efficiency".  This isn't true with modern TCG, so
> replace this comment with one which notes that they're only used with
> the iwmmxt decode.
> 
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reply via email to