On 8/7/20 4:26 PM, Paolo Bonzini wrote:
> On 07/08/20 15:20, Philippe Mathieu-Daudé wrote:
>>> endif
>>>
>>> + if host_machine.system() == 'linux'
>>> + executable('qemu-bridge-helper', files('qemu-bridge-helper.c'),
>>> + dependencies: [qemuutil, libcap_ng],
>> Is libcap_ng still optional?
>>
>
> Yes, if a dependency is absent it is simply left out. See
> contrib/vhost-user-scsi for an example where the executable is disabled.
>
> Instead, if you want a dependency to be mandatory you have two choices:
>
> - to break the build you use "required: true", see the SDL conversion
> for an example
OK, good :)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
>
> - to disable executables there is a thing called disabler but we're not
> using it because it's confusing. I was thinking of adding an
> "or_disable()" method to dependency objects, but I have never
> contributed it.
>
> Paolo
>
