On 8/11/20 10:54 AM, Nir Soffer wrote:
On Tue, Aug 11, 2020 at 11:08 AM Max Reitz <mre...@redhat.com> wrote:
The error message has changed recently, breaking the test. Fix it.
Fixes: a2b333c01880f56056d50c238834d62e32001e54
("block: nbd: Fix convert qcow2 compressed to nbd")
Thanks for fixing this. I thought that I ran all the tests when I submitted
the change.
Is this new test that was not available in master when I submitted this, or
maybe I
missed something when running the tests?
More likely the latter. 'make check' runs a subset of iotests under a
subset of options, so this must not have been one of those options (or
CI would have caught it sooner). Running it manually with './check -nbd
256' sees it, though.
I think I ran the tests using:
SPEED=thorough check-block.sh
My fault as well, since it was a rather late patch and I was trying to
get it in -rc3, so I didn't complete as many tests on it as I would have
liked before submitting the pull request. Ah well, it won't be the
first release with a broken iotest. (Or if we really _do_ need -rc4, I
can add this to the queue of nice-to-have)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
