Patchew URL: https://patchew.org/QEMU/20200813032537.2888593-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200813032537.2888593-1-richard.hender...@linaro.org Subject: [PATCH 00/17] crypto/cipher: Class hierarchy cleanups === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200813032537.2888593-1-richard.hender...@linaro.org -> patchew/20200813032537.2888593-1-richard.hender...@linaro.org Switched to a new branch 'test' a39d494 crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses ca787d9 crypto/nettle: Split QCryptoCipherNettle into subclasses 81bf19b crypto/builtin: Split QCryptoCipherBuiltin into subclasses 11aed74 crypto/builtin: Split and simplify AES_encrypt_cbc c628150 crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c 3707370 crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt efe1005 crypto/builtin: Remove odd-sized AES block handling 628aa8a crypto: Constify cipher data tables 01f1215 crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new 93dc38a crypto: Allocate QCryptoCipher with the subclass 81aaa54 crypto: Use the correct const type for driver 8c43775 crypto/nettle: Fix xts_encrypt arguments f7c0f04 crypto: Remove redundant includes 490fd1b crypto: Rename cipher include files to .inc.c 4ba136f crypto: Assume blocksize is a power of 2 bf305e2 crypto: Move QCryptoCipherDriver typedef to qemu/typedefs.h 680954e crypto: Move QCryptoCipher typedef to qemu/typedefs.h === OUTPUT BEGIN === 1/17 Checking commit 680954e19b44 (crypto: Move QCryptoCipher typedef to qemu/typedefs.h) 2/17 Checking commit bf305e28fb65 (crypto: Move QCryptoCipherDriver typedef to qemu/typedefs.h) 3/17 Checking commit 4ba136fd50f5 (crypto: Assume blocksize is a power of 2) 4/17 Checking commit 490fd1bf6368 (crypto: Rename cipher include files to .inc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: rename from crypto/cipher-builtin.c total: 0 errors, 1 warnings, 14 lines checked Patch 4/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/17 Checking commit f7c0f04877bd (crypto: Remove redundant includes) 6/17 Checking commit 8c4377523504 (crypto/nettle: Fix xts_encrypt arguments) 7/17 Checking commit 81aaa54855c5 (crypto: Use the correct const type for driver) 8/17 Checking commit 93dc38a2a468 (crypto: Allocate QCryptoCipher with the subclass) 9/17 Checking commit 01f121573c8b (crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new) 10/17 Checking commit 628aa8ac5fbc (crypto: Constify cipher data tables) 11/17 Checking commit efe100595b61 (crypto/builtin: Remove odd-sized AES block handling) 12/17 Checking commit 3707370f4f52 (crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt) 13/17 Checking commit c6281504f1df (crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c) 14/17 Checking commit 11aed74bf453 (crypto/builtin: Split and simplify AES_encrypt_cbc) 15/17 Checking commit 81bf19bde54b (crypto/builtin: Split QCryptoCipherBuiltin into subclasses) 16/17 Checking commit ca787d9c34d4 (crypto/nettle: Split QCryptoCipherNettle into subclasses) ERROR: Macros with multiple statements should be enclosed in a do - while loop #257: FILE: crypto/cipher-nettle.inc.c:255: +#define DEFINE_XTS(NAME, TYPE, BLEN, ENCRYPT, DECRYPT) \ + QEMU_BUILD_BUG_ON(BLEN != XTS_BLOCK_SIZE); \ + DEFINE__XTS(NAME, TYPE, BLEN, ENCRYPT, DECRYPT) \ +static const struct QCryptoCipherDriver NAME##_driver_xts = { \ + .cipher_encrypt = NAME##_encrypt_xts, \ + .cipher_decrypt = NAME##_decrypt_xts, \ + .cipher_setiv = NAME##_setiv, \ + .cipher_free = qcrypto_cipher_ctx_free, \ +}; total: 1 errors, 0 warnings, 973 lines checked Patch 16/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/17 Checking commit a39d494a93ce (crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200813032537.2888593-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com