Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group()

[Pierre Morel]

On 2020-08-14 18:02, Pan Nengyuan wrote:

Missing g_error_free() in vfio_ap_get_group() error path. Fix that.

Reported-by: Euler Robot <euler.ro...@huawei.com>
Signed-off-by: Pan Nengyuan <pannengy...@huawei.com>
---
Cc: Cornelia Huck <coh...@redhat.com>
Cc: Thomas Huth <th...@redhat.com>
Cc: Christian Borntraeger <borntrae...@de.ibm.com>
Cc: Tony Krowiak <akrow...@linux.ibm.com>
Cc: Halil Pasic <pa...@linux.ibm.com>
Cc: Pierre Morel <pmo...@linux.ibm.com>
Cc: Alex Williamson <alex.william...@redhat.com>
Cc: qemu-s3...@nongnu.org
---
  hw/vfio/ap.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index b9330a8e6f..cec6fe1599 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -71,6 +71,7 @@ static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, 
Error **errp)
      if (!group_path) {
          error_setg(errp, "%s: no iommu_group found for %s: %s",
                     VFIO_AP_DEVICE_TYPE, vapdev->vdev.sysfsdev, 
gerror->message);
+        g_error_free(gerror);
          return NULL;
      }

Thanks Pan,

Reviewed-by: Pierre Morel <pmo...@linux.ibm.com>


--
Pierre Morel
IBM Lab Boeblingen