On Mon, Aug 17, 2020 at 09:07:58PM +0200, Niek Linnenbank wrote: > Hi, > > Interesting suggestion Philippe. I modelled the initial code of the H3 SoC > mostly in-line with the aspeed SoC, > to let it use commonly applied code structures where possible. And it looks > like in this series, aspeed_soc.h is also > getting the same change. I'll see if I can find some time to make a small > patch to move the enum to the local allwinner-h3.c file like you > suggested. > > For Eduardo's work, I'm OK with a rename for now to AW_H3_DEV_*. I see it > is also done like that in aspeed_soc.h and similar files. > I do have one follow-up question: which value(s) from the enum are actually > in conflict? Could you add that in the commit message perhaps, for clarity?
For allwinner-h3, the conflicting macros are: AW_H3_CCU, AW_H3_SYSCTRL. v2 of the series will have the conflicting macros mentioned in the commit message in all the "rename enum constants" patches. > > With that answered: > Reviewed-by: Niek Linnenbank <nieklinnenb...@gmail.com> Thanks! -- Eduardo
