On Wed, Aug 19, 2020 at 03:08:42PM +0200, Cédric Le Goater wrote: I can see why this is a good idea, but it really needs a rationale in the comment for posterity.
> Signed-off-by: Cédric Le Goater <c...@kaod.org>
> ---
> hw/ppc/spapr_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c
> index 80cf1c3d6bb2..d036c8fef519 100644
> --- a/hw/ppc/spapr_irq.c
> +++ b/hw/ppc/spapr_irq.c
> @@ -172,7 +172,7 @@ static int spapr_irq_check(SpaprMachineState *spapr,
> Error **errp)
> * To cover both and not confuse the OS, add an early failure in
> * QEMU.
> */
> - if (spapr->irq == &spapr_irq_xive) {
> + if (!spapr->irq->xics) {
> error_setg(errp, "XIVE-only machines require a POWER9 CPU");
> return -1;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
