On Fri, Aug 21, 2020 at 09:06:51AM -0700, Alistair Francis wrote: > On Thu, Aug 20, 2020 at 2:56 PM Eduardo Habkost <ehabk...@redhat.com> wrote: > > > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is not set, despite having type > > checker macros that use a specific type. > > > > The ones with "WARNING" are abstract types (maybe not serious if > > subclasses set the appropriate sizes). The ones with "ERROR" > > don't seem to be abstract types. > > > > > ERROR: hw/core/register.c:328:1: instance_size should be set to > > sizeof(RegisterInfo)? > > I'll send a patch out for this one today. > > If you are fixing all of these as part of a series I'm also happy to > just let you do that.
Feel free to send the fix, and I will include it as part of my series if necessary. Note that register_init_block() relies on the fact that register_init() won't touch any RegisterInfo field except parent_obj, so this won't be a one line patch. -- Eduardo