Great, thanks! Can you send it as a patch? I am collecting Meson fixes and I should be able to send a pull request this week.
Also if you can please test the msys fixes that were sent on the list that would be great. Paolo Il mar 25 ago 2020, 09:52 Mark Cave-Ayland <[email protected]> ha scritto: > On 24/08/2020 12:37, Gerd Hoffmann wrote: > > >> 2) GTK UI now depends on CONFIG_VTE > >> > >> This one I spotted on my local Linux setup as I didn't have the > libvte-dev package > >> installed and couldn't understand why I couldn't run QEMU with the GTK > UI as I always > >> do, even though configure reported that it found the GTK library and > headers. > >> > >> A quick search showed that the GTK UI was being guarded by "if > >> config_host.has_key('CONFIG_GTK') and > config_host.has_key('CONFIG_VTE')" in > >> ui/meson.build. > > > > That is not correct. vte is intentionally not a hard dependency ... > > > >> For me the easy solution was to install libvte-dev, but since there are > no VTE > >> packages for Windows my guess is this will now make the GTK UI > unavailable for > >> Windows users. > > > > .. because we don't have that on windows. > > > > I think simply dropping the "and config_host.has_key('CONFIG_VTE')" > > should work, can you try that? > > Hi Gerd, > > I can't get the native Windows build to complete yet, however I've removed > the > libvte-dev headers again on my Linux setup and confirmed that GTK works > once again > with the below diff: > > diff --git a/ui/meson.build b/ui/meson.build > index 81fd393432..cc71f51f37 100644 > --- a/ui/meson.build > +++ b/ui/meson.build > @@ -42,7 +42,7 @@ if config_host.has_key('CONFIG_CURSES') > ui_modules += {'curses' : curses_ss} > endif > > -if config_host.has_key('CONFIG_GTK') and config_host.has_key('CONFIG_VTE') > +if config_host.has_key('CONFIG_GTK') > softmmu_ss.add(when: 'CONFIG_WIN32', if_true: files('win32-kbd-hook.c')) > > gtk_ss = ss.source_set() > > > ATB, > > Mark. > >
