Chen Qun <kuhn.chen...@huawei.com> writes:
> Clang static code analyzer show warning:
> qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read
> pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
>
> Reported-by: Euler Robot <euler.ro...@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
> ---
> Cc: Gerd Hoffmann <kra...@redhat.com>
> Cc: Markus Armbruster <arm...@redhat.com>
> ---
> hw/usb/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/usb/bus.c b/hw/usb/bus.c
> index b17bda3b29..7bab0499ad 100644
> --- a/hw/usb/bus.c
> +++ b/hw/usb/bus.c
> @@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev)
if (in[0] == '.') {
/* some hub between root port and device */
pos += snprintf(fw_path + pos, fw_len - pos, "hub@%lx/", nr);
> in++;
> } else {
> /* the device itself */
> - pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
> - qdev_fw_name(qdev), nr);
> + snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
> qdev_fw_name(qdev),
> + nr);
> break;
> }
> }
I'd prefer to keep the line break where it is:
snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
qdev_fw_name(qdev), nr);
The patch is safe, so
Reviewed-by: Markus Armbruster <arm...@redhat.com>
The loss of symmetry betwen the two arms of the if is a bit sad. Up to
Gerd.
