Blue Swirl <blauwir...@gmail.com> writes: > On Wed, Aug 3, 2011 at 1:07 PM, Markus Armbruster <arm...@redhat.com> wrote: >> No functional change. >> >> It would be nice to have handler functions in the table, like commit >> e1a064f9 did for ATAPI. Left for another day. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> hw/ide/core.c | 104 >> +++++++++++++++++++++++++++++++++++++++++++-------------- >> 1 files changed, 79 insertions(+), 25 deletions(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index 1c4dc2f..a25c175 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -876,6 +876,77 @@ void ide_ioport_write(void *opaque, uint32_t addr, >> uint32_t val) >> } >> } >> >> +#define HD_OK (1u << IDE_HD) >> +#define CD_OK (1u << IDE_CD) >> +#define CFA_OK (1u << IDE_CFATA) >> +#define HD_CFA_OK (HD_OK | CFA_OK) >> +#define ALL_OK (HD_OK | CD_OK | CFA_OK) >> + >> +/* See ACS-2 T13/2015-D Table B.2 Command codes */ >> +uint8_t ide_cmd_table[0x100] = { > > Missing 'static'.
Thanks, will fix. [...]