On 8/18/20 8:50 AM, Taylor Simpson wrote: > +#ifndef HEXAGON_REGMAP_H > +#define HEXAGON_REGMAP_H > + > + /* Name Num Table */ > +DEF_REGMAP(R_16, 16, 0, 1, 2, 3, 4, 5, 6, 7, 16, 17, 18, 19, 20, 21, 22, 23) > +DEF_REGMAP(R__8, 8, 0, 2, 4, 6, 16, 18, 20, 22) > +DEF_REGMAP(R__4, 4, 0, 2, 4, 6) > +DEF_REGMAP(R_4, 4, 0, 1, 2, 3) > +DEF_REGMAP(R_8S, 8, 0, 1, 2, 3, 16, 17, 18, 19) > +DEF_REGMAP(R_8, 8, 0, 1, 2, 3, 4, 5, 6, 7) > +DEF_REGMAP(V__8, 8, 0, 4, 8, 12, 16, 20, 24, 28) > +DEF_REGMAP(V__16, 16, 0, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, > 30)
Given that DEF_REGMAP itself is defined in decode.c, and not even in another header file, why do these not live in decode.c as well? r~